gh-88831: In docs for asyncio.create_task, explain why strong references to tasks are needed#93258
Merged
ambv merged 4 commits intopython:mainfrom Jun 7, 2022
agrommek:augment_asyncio_create_task_docs
Merged
gh-88831: In docs for asyncio.create_task, explain why strong references to tasks are needed#93258ambv merged 4 commits intopython:mainfrom agrommek:augment_asyncio_create_task_docs
ambv merged 4 commits intopython:mainfrom
agrommek:augment_asyncio_create_task_docs
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everybody,
this is a small PR augmenting the documentation of
asyncio.create_task(). The documentation states that one has to keep a reference to all running tasks, but most of the time it also works when you don't. This led to a bit of head-scratching on my part (see https://stackoverflow.com/questions/71938799/python-asyncio-create-task-really-need-to-keep-a-reference) until I discovered #88831 (which led me to create this PR to solve this issue).If accepted, this PR should probably be backported to versions starting from 3.7, i.e. all versions having
asyncio.create_task().This PR might have relevance for issue #91887: If the
asyncioevent loop keeps strong references itself one day, the information added with this PR can be removed again.